-
Notifications
You must be signed in to change notification settings - Fork 1
Description
--- As of 2026-02-10T22:17:13.000Z ---
Kyotaro Horiguchi submitted patches addressing various PostgreSQL error message issues including non-standard wording, grammatical mistakes, and formatting inconsistencies. The patches covered problems in guc_table.c (using "Show" instead of "Shows"), partbounds.c (inconsistent hint message structures and incorrect present tense usage), wait.c (inconsistent "timeout value" vs "timeout" wording), and extended_stats_funcs.c (double quoting issues from combining quote_identifier() with format string quotes). However, Horiguchi noted the initial patch set caused test failures. Michael Paquier and Álvaro Herrera provided feedback on the quoting issues, with Tom Lane clarifying that quote_identifier() should not be used in error messages as it conflicts with PostgreSQL's style guide for translatable messages. Michael Paquier subsequently committed fix f33c58577422 removing the quote_identifier() calls and adjusting the error string formatting to match project standards.
Kyotaro Horiguchi提交了补丁,解决PostgreSQL错误消息中的各种问题,包括非标准措辞、语法错误和格式不一致。补丁涵盖了guc_table.c(使用"Show"而非"Shows")、partbounds.c(提示消息结构不一致和错误的现在时用法)、wait.c("timeout value"与"timeout"措辞不一致)和extended_stats_funcs.c(quote_identifier()与格式字符串引号结合导致的双引号问题)中的问题。然而,Horiguchi指出初始补丁集导致了测试失败。Michael Paquier和Álvaro Herrera对引号问题提供了反馈,Tom Lane澄清了在错误消息中不应使用quote_identifier(),因为它与PostgreSQL可翻译消息的样式指南冲突。Michael Paquier随后提交了修复f33c58577422,移除了quote_identifier()调用并调整错误字符串格式以符合项目标准。
participants - 参与者: