Buffer locking is special (hints, checksums, AIO writes) #179
Description
--- As of 2026-02-15T19:52:39.000Z ---
Noah Misch reviewed patch v12-0001 addressing heap_inplace_update_and_unlock() functionality and found it acceptable. The patch modifies how MarkBufferDirtyHint() operates by removing its previous approach and implementing an alternative method that delays updating buffer contents. Heikki Linnakangas suggested clarifying a comment about memcpy() usage, proposing text that explains the temporary buffer copy mechanism used to hide changes from other backends until WAL logging completes. Noah responded that while either version is acceptable, he mildly prefers the original v12 version, finding Heikki's proposed text redundant with existing nearby comments about registering blocks that match post-change buffer state.
Noah Misch审查了解决heap_inplace_update_and_unlock()功能的补丁v12-0001，认为该补丁是可接受的。该补丁修改了MarkBufferDirtyHint()的操作方式，移除了之前的方法并实现了一种延迟更新缓冲区内容的替代方法。Heikki Linnakangas建议澄清关于memcpy()使用的注释，提议使用解释临时缓冲区复制机制的文本，该机制用于在WAL日志记录完成之前向其他后端隐藏更改。Noah回应说虽然两个版本都可以接受，但他稍微偏好原始的v12版本，认为Heikki提议的文本与附近关于注册匹配更改后缓冲区状态的块的现有注释重复。
participants - 参与者: