Bugfix 49 - Adds safety checks for optional button pins #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents GPIO configuration and reading when button pins are set to invalid values (negative numbers). Allows InputController to gracefully handle cases where one or both buttons are not physically connected by treating unconfigured pins as permanently unpressed.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds safety checks to prevent GPIO configuration and reading when button pins are set to invalid values, addressing issue #49. The changes allow the InputController to gracefully handle cases where one or both buttons are not physically connected.
- Adds pin validation checks before configuring GPIO pins with
pinMode() - Adds pin validation checks before reading button states with
digitalRead() - Treats unconfigured pins (negative values) as permanently unpressed buttons
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Added an extra condition to the input controller button input method, preventing a digitalRead call on invalid pin numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #49
Prevents GPIO configuration and reading when button pins are set to invalid values (negative numbers).
Allows InputController to gracefully handle cases where one or both buttons are not physically connected by treating unconfigured pins as permanently unpressed.