-
Notifications
You must be signed in to change notification settings - Fork 11
C model doc update #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C model doc update #432
Conversation
WalkthroughAdds F4E GitLab-backed input fetching with token support, extends IAEA fetch plumbing, and updates app flow to optionally fetch from F4E. Introduces a new tally modifier (cumulative_sum) with revised error propagation, OpenMC compiled source handling, non-interactive plotting backend, config/docs updates, CI tweaks, and new/updated tests and fixtures. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant App as jade.app.app:update_inputs
participant IAEA as IAEA Repo
participant F4E as F4E GitLab
Note over App: Start inputs update
User->>App: update_inputs()
App->>IAEA: fetch_iaea_inputs()
alt IAEA fetch ok
App-->>User: IAEA updated
else IAEA fetch failed
App-->>User: Log IAEA failure
alt F4E_GITLAB_TOKEN present
App->>F4E: fetch_f4e_inputs(token)
alt F4E fetch ok
App-->>User: F4E updated
else F4E fetch failed
App-->>User: Log F4E failure
end
else No token
App-->>User: Skip F4E update
end
end
sequenceDiagram
autonumber
participant Client
participant Fetch as jade.app.fetch.fetch_from_gitlab
participant GL as GitLab API
participant Zip as Archive
participant FS as Filesystem
Client->>Fetch: url, path_with_namespace, branch, token
Fetch->>GL: authenticate(token)
Fetch->>GL: get project(path_with_namespace)
Fetch->>GL: download repo archive(branch, zip)
GL-->>Fetch: zip content
Fetch->>Zip: _extract_zip(content, tmpdir)
Zip-->>Fetch: extracted_root_path
Fetch->>FS: _install_standard_folder_structure(extracted_root, inputs_root, exp_root, ...)
FS-->>Fetch: success/failure
Fetch-->>Client: PathLike|bool
sequenceDiagram
autonumber
participant Builder as InputOpenMC
participant FS as Filesystem
participant OpenMC as openmc.Settings
Note over Builder: Initialization
Builder->>FS: Check for libsource.so
alt libsource.so exists
Builder-->>Builder: compiled_source = path
else
Builder-->>Builder: compiled_source = None
end
Note over Builder: Write
Builder->>FS: export geometry/materials/tallies/settings
alt compiled_source available
Builder->>FS: copy libsource.so to output
Builder->>OpenMC: settings.source = CompiledSource(libsource.so)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
dodu94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Please include a summary of the changes and the related issue (if applicable). Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #415
Type of change
Doc update
Summary by CodeRabbit