Skip to content

Build UE Plugin with CMake and minore fixes #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JBenda merged 11 commits into from
Feb 15, 2025
Merged

Build UE Plugin with CMake and minore fixes #99

JBenda merged 11 commits into from
Feb 15, 2025

Conversation

@JBenda
Copy link
Owner

@JBenda JBenda commented Feb 15, 2025

  • Supports now compiling the UE Plugin via cmake if the path to the RunUAT is given.
  • Fixes eval_stack fill up caused by not cleaning it after choices (InkAssert when string_table is filled up #97)
  • Remove dot in output on Windows for floating-point numbers where f == int(f)
  • Cast char to unsigned char to avoid errors with isspace

@JBenda JBenda added the enhancement New feature or request label Feb 15, 2025
@JBenda JBenda self-assigned this Feb 15, 2025
@JBenda JBenda mentioned this pull request Feb 15, 2025
Closed
@JBenda
Cmake Variable enhancments
601e52f 
+ Increase readability for cmake-gui
+ Add help text when building the documentation to show where to access
@JBenda
Start adding unreal compilation
54ee5ea
@JBenda
Use configure_file to copy UE plugin at one place
3cdd835
@JBenda
First plugin build with cmaek
c1a87a8
@JBenda
Pytest better error handling
a24c442 
+ added progress bar for compiling stories
@JBenda
clear eval stack after each choice since artifacts of choices can be …
dd1342e 
…on there
@JBenda
Fixes Windows Ink-Proofs
7ce77c3 
+ fix formatting of flotaing point numbers
+ cast for isspace to unsigned to support unicode
@JBenda
formatting
0805430
@JBenda
formatting
7966419
@github-actions
Copy link

github-actions bot commented Feb 15, 2025

Ink Proof Results

These results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.

System Results
Linux x64 130/130 passed
MacOSX-ARM DISABLED
MacOSX DISABLED
Windows x64 130/130 passed

@JBenda JBenda marked this pull request as ready for review February 15, 2025 23:21
@JBenda JBenda merged commit 55dc04e into master Feb 15, 2025
14 checks passed
@JBenda JBenda deleted the UEPluginWithCMake branch February 15, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JBenda JBenda

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JBenda