Allow missing/empty cycle time files in timeseries #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danholdaway
requested changes
Nov 15, 2024
Collaborator
danholdaway
left a comment
danholdaway
left a comment
There was a problem hiding this comment.
Could you add some testing to show the use case of this feature?
Contributor
Author
Yes, this PR is currently a draft |
danholdaway
approved these changes
Nov 21, 2024
Collaborator
danholdaway
left a comment
danholdaway
left a comment
There was a problem hiding this comment.
Nice feature and thanks for adding testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demonstration
Comparing two time series of different lengths:
Timeseries with a missing cycle time:
