Skip to content

remove internal#1

Merged
snyderdad merged 2 commits intomasterfrom
feature/remove-internal
Sep 24, 2021
Merged

remove internal#1
snyderdad merged 2 commits intomasterfrom
feature/remove-internal

Conversation

@mer-a-o
Copy link
Copy Markdown
Collaborator

@mer-a-o mer-a-o commented Sep 24, 2021

Use this template to give a detailed message describing the change you want to make to the code.
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for more guidance

The title of this pull request should be a brief "purpose" for this change.

--- Delete this line and those above before hitting "Create pull request" ---

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: approximately 3 to 6 words (more is always better) related to your commit, separated by commas

DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.

ISSUE: For use when this PR closes a Zenhub issue. For issue number 123

Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status develop to get formatted list)

TESTS CONDUCTED: Explicitly state what testing was performed.

Comment thread CMakeLists.txt
ecbuild_bundle( PROJECT crtm GIT "https://github.com/jcsda/crtm.git" TAG v2.3-jedi.3 )
option(BUNDLE_SKIP_RTTOV "Don't build rttov" "ON") # Skip rttov build unless user passes -DBUNDLE_SKIP_RTTOV=OFF
ecbuild_bundle( PROJECT rttov GIT "https://github.com/JCSDA-internal/rttov.git" BRANCH develop UPDATE )
ecbuild_bundle( PROJECT rttov GIT "https://github.com/JCSDA/rttov.git" BRANCH develop UPDATE )
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should JCSDA be lower-case here?

@snyderdad snyderdad merged commit 86a193f into master Sep 24, 2021
@snyderdad snyderdad deleted the feature/remove-internal branch September 24, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants