Skip to content

[release/2.1] Update netcdf-c from spack develop to fix missing plugins#58

Open
climbfuji wants to merge 16 commits intoJCSDA:release/2.1from
climbfuji:feature/update_netcdf_c_from_upstream_rel21
Open

[release/2.1] Update netcdf-c from spack develop to fix missing plugins#58
climbfuji wants to merge 16 commits intoJCSDA:release/2.1from
climbfuji:feature/update_netcdf_c_from_upstream_rel21

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Apr 29, 2026

Description

This PR cherry-picks a series of commits from spack develop to fix the issue with missing plugins reported in JCSDA/spack-stack#1997. This PR is for release/2.1.

Because I cherry-picked the commits, other files are updated as well. I believe this is ok. I could go in and manually undo those changes in a single commit and then remove this commit when merging the changes down to develop. Thoughts?

Testing

See JCSDA/spack-stack#2010

wdconinc and others added 16 commits April 29, 2026 09:56
Even though netcdf-c is only supposed to depend on curl when +dap, it doesn't correctly do this until 4.9.3

* ensure netcdf-c depends_on curl

* Apply only when build_system=cmake
* Patch the networkdirect and msmpi package build systems to be
  compatible with being built and installed in stages and prefixes
  whose paths contain spaces
* Add mpi to the Windows gitlab CI by enabling the +mpi variant of
  vtk and paraview
* Add patch to fix netcdf-c build error on Windows (Paraview
  dependency)
* Tweak seacas dependencies on Windows (vtk dependency)
* Add external win-wdk entry to the GL CI packages.yaml that
  corresponds to the existing win-sdk version
…3.9.3 update (spack#1157)

* netcdfc: ensure patchs are applied to only appropriate versions
* NetcdfC: update and add patches
* Update version boundaries on MPI CSD patch
* Add include patch for 4.9.3
* netcdf: patch to utf-8

---------

Signed-off-by: John Parent <john.parent@kitware.com>
…spack#1712)

Netcdf-c && Proj Fixes for CMake based Curl (fixes broken develop CI)

Signed-off-by: John Parent <john.parent@kitware.com>
* do not use deprecated argument

* conflict the removed jna feature

* add new byterange requirement

* use new option for blosc

* use new option for zstd

* handle bz2
* Logic to install plugins for cmake netcdf-c builds
…ind MPI functions when build system is cmake
…ith intel-oneapi-compilers+intel-oneapi-mpi and gcc+openmpi
Explicitly set CMAKE_INSTALL_RPATH_USE_LINK_PATH to TRUE
Otherwise CMake will choke on a Windows escape character if based in the C: drive

Signed-off-by: John Parent <john.parent@kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

6 participants