Skip to content

WCOSS2/1.9.2(rc1)#1652

Merged
AlexanderRichert-NOAA merged 12 commits intoJCSDA:release/1.9.0from
AlexanderRichert-NOAA:192
Jun 3, 2025
Merged

WCOSS2/1.9.2(rc1)#1652
AlexanderRichert-NOAA merged 12 commits intoJCSDA:release/1.9.0from
AlexanderRichert-NOAA:192

Conversation

@AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented May 27, 2025

Summary

This PR provides major updates to the WCOSS2 site config, including adding oneAPI compilers, and makes some updates for various recipes (such as adding commit hashes for resources to enable prefetching, and some patching). Once merged, I intend to create a spack-stack-1.9.2rc1 tag on the release/1.9.0 branch.
Edit: Also updates unit test workflow to use ubuntu-latest.

Testing

Testing in progress on Acorn

Applications affected

Changes target NCO; packages modified are used by most applications

Systems affected

Mainly WCOSS2 site config, but package changes affect all systems

Dependencies

JCSDA/spack#544

Issue(s) addressed

Part of NOAA-EMC/WCOSS2-requests#40

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

…g oneAPI compilers.

* wcoss2/compilers.yaml: add oneapi (with gcc12 backend) and gcc12

* wcoss2: add separate packages_intel.yaml

* nco template: don't specify compilers for individual packages

* parallel_install.sh: append output

* wcoss2: update packages.yaml
@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review May 29, 2025 02:07
@AlexanderRichert-NOAA AlexanderRichert-NOAA changed the title WCOSS2/1.9.2 WCOSS2/1.9.2(rc1) May 29, 2025
@AlexanderRichert-NOAA
Copy link
Collaborator Author

@climbfuji looks like the runners are out of disk space?

@climbfuji
Copy link
Collaborator

@climbfuji looks like the runners are out of disk space?

I'll look into this first thing Monday morning!

@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA I freed up space on the runner. I can't push to your branch to trigger the tests, can you try please?

@AlexanderRichert-NOAA
Copy link
Collaborator Author

@climbfuji linux workflows completed 👍 but macos one is still "waiting for a runner". I'm hoping we can get these merged by tomorrow morning 🤞

@climbfuji
Copy link
Collaborator

I merged the spack PR. Please go ahead and update the submodule pointer here. I'll look at the macos CI runner, but if it doesn't run then I suggest we go ahead and merge with the Linux tests passing only.

@AlexanderRichert-NOAA
Copy link
Collaborator Author

I updated the submodule, but I'm a bit confused as to how these are normally set up. I have it pointing to the correct commit hash, which I've also tagged as spack-stack-1.9.2rc1, however it looks like for 1.9.1 for example, .gitmodules contains 'branch = spack-stack-1.9.1' but I didn't think that was legal? In any case git won't let me do that directly so I think I'm missing something...

@climbfuji
Copy link
Collaborator

I updated the submodule, but I'm a bit confused as to how these are normally set up. I have it pointing to the correct commit hash, which I've also tagged as spack-stack-1.9.2rc1, however it looks like for 1.9.1 for example, .gitmodules contains 'branch = spack-stack-1.9.1' but I didn't think that was legal? In any case git won't let me do that directly so I think I'm missing something...

We've been doing this ever since, use branch=tag-name instead of branch=branch-name. What isn't working when you do this? The .gitmodules` entry isn't really used, it's more for documentation purposes and us developers. Git goes by the commit hash that is stored as submodule pointer.

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Ok I think that clears it up, thanks. This should be good to go now.

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit de32186 into JCSDA:release/1.9.0 Jun 3, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants