Fix mirroring of specific specs#545
Merged
climbfuji merged 1 commit intoJCSDA:spack-stack-devfrom May 31, 2025
Merged
Conversation
* cmd/mirror.py: match CLI specs to concrete specs in env * Allow using 'mirror create -a/--all' to match multiple concrete specs * remove unit test preventing 'mirror create -a <spec>' * Add test_mirror_spec_from_env() unit test (cmd/mirror.py)
climbfuji
approved these changes
May 31, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the changes from spack#50307, which will allow the
spack mirror createto use the existing concretization to decide which packages to grab, which is generally necessary when only source mirroring a subset of packages in an environment. This in turn will let me simplify the weekly build logic for Acorn :)Tested on Acorn.
Fixes JCSDA/spack-stack#1646