Skip to content

Conversation

@bpbond
Copy link
Member

@bpbond bpbond commented Nov 8, 2017

This is a frequent source of join problems. Includes test code. Addresses #802 .

This is a frequent source of join problems. Includes test code.
Addresses #802 .
@bpbond bpbond requested a review from rplzzz November 8, 2017 22:26
@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #820 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   92.17%   92.19%   +0.01%     
==========================================
  Files          11       11              
  Lines        1317     1320       +3     
==========================================
+ Hits         1214     1217       +3     
  Misses        103      103
Impacted Files Coverage Δ
R/driver.R 80.56% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10d076...4706985. Read the comment docs.

# Conflicts:
#	R/zchunk_L112.ghg_en_R_S_T_Y.R
#	R/zchunk_L115.nh3_an_R_S_T_Y.R
#	R/zchunk_L222.en_transformation.R
#	R/zchunk_L226.en_distribution.R
@bpbond
Copy link
Member Author

bpbond commented Nov 14, 2017

Note: @rplzzz asked about whether year should be enforced as integer, not just (as here) numeric. I looked into this but to do this right I think we'd want to go back and e.g. change the system-wide constant to HISTORICAL_YEARS <- 1971L:2010L. I'm opening issue #826 to follow up on this.

@bpbond bpbond merged commit 31284f7 into master Nov 14, 2017
@bpbond bpbond deleted the year-col-numeric branch November 14, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants