Skip to content

Fix ruff + mypy CI job failure by resolving Ruff violations in Phase 4 additions#24

Merged
crvernon merged 8 commits into
version/2.0.0-phase4-ai-assistantsfrom
copilot/fix-ruff-mypy-job-failure
May 20, 2026
Merged

Fix ruff + mypy CI job failure by resolving Ruff violations in Phase 4 additions#24
crvernon merged 8 commits into
version/2.0.0-phase4-ai-assistantsfrom
copilot/fix-ruff-mypy-job-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

The failing ruff + mypy GitHub Actions job was blocked by Ruff errors introduced in the Phase 4 branch. This PR applies minimal, targeted fixes to clear those lint violations and restore the job path.

  • Ruff cleanup in session planning logic

    • Removed an unused import in scalable/session/session.py (dataclasses.replace).
  • Ruff cleanup in new AI/unit tests

    • Fixed import block ordering/formatting in tests/unit/test_ai_explain.py.
    • Renamed ambiguous comprehension variable in tests/unit/test_ai_onboarding.py (lline).
    • Renamed unused loop variable in tests/unit/test_session_plan_objectives.py (tag_tag).
  • Workflow hardening surfaced during validation

    • Added explicit token permissions to .github/workflows/tests.yml:
      permissions:
        contents: read

Example of the lint-focused code change pattern:

# before
yaml_lines = [l for l in lines if not l.startswith("#")]

# after
yaml_lines = [line for line in lines if not line.startswith("#")]

Copilot AI and others added 3 commits May 19, 2026 23:59
Co-authored-by: crvernon <3947069+crvernon@users.noreply.github.com>
Co-authored-by: crvernon <3947069+crvernon@users.noreply.github.com>
@crvernon crvernon marked this pull request as ready for review May 20, 2026 00:00
@crvernon crvernon changed the base branch from main to version/2.0.0-phase4-ai-assistants May 20, 2026 00:02
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'ruff + mypy' Fix ruff + mypy CI job failure by resolving Ruff violations in Phase 4 additions May 20, 2026
@crvernon crvernon merged commit 10f57eb into version/2.0.0-phase4-ai-assistants May 20, 2026
6 checks passed
Copilot AI requested a review from crvernon May 20, 2026 00:02
@crvernon crvernon deleted the copilot/fix-ruff-mypy-job-failure branch May 20, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants