Core#3
Merged
Merged
Conversation
Owner
JJCoding01
commented
Oct 17, 2020
JJCoding01
commented
- Move common/private functionality into core module
- Add some type hints for mypy
- Restructure tests to use pytest fixtures and parametrized tests
- Add make commands for building and publishing to PyPi
Functions that require value validation now have the validation in the function body itself, instead of abstracting the validation out to a separate class. This was done due to issues when implementing type checking using mypy and the second decorator on class functions.
- Change base classes to be abstract - Add boundary property to all reaction classes - Add @staticmethod decorator to __get_nodes
Disable flake8 errors for PyPep8Naming specific PyUnresolvedReferencesAdd Disable the PyPep8Naming for certain classes to allow variable names to follow engineering conventions. (ie E for Young's modulus, and I for area moment of inertia) Disable PyUnresolvedReferencesAdd on select numpy functions. Not sure why they are getting marked as unresolved.
No changes to external functionality, improvements to organize internal modules only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.