Fix usability with assembly workbenches #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address the issue where it was impossible to use simple groups in assembly workbenches, by adding an additional check to deal with this case.
EvanLF6768
changed the title
Contributor
Author
|
As I wanted to minimize excessive changes to the code you are required to select both the part(s) in the assembly hierarchy as well as a face in the model to act as the direction. This is inconsistent with the ability to simply click once in the 3D view, but is not a regression as this method is only required for assemblies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 Partially
Address the issue where it was impossible to use simple groups in assembly workbenches, by adding an additional check to deal with this case.
Note only simple groups have been fixed with this commit.