Skip to content

PR for #150: Fix bugs encountered while onboarding actions#151

Merged
liaochris merged 14 commits intomainfrom
150-fix-bugs-in-github-actions
Apr 16, 2026
Merged

PR for #150: Fix bugs encountered while onboarding actions#151
liaochris merged 14 commits intomainfrom
150-fix-bugs-in-github-actions

Conversation

@liaochris
Copy link
Copy Markdown
Collaborator

No description provided.

@liaochris liaochris linked an issue Apr 6, 2026 that may be closed by this pull request
@liaochris liaochris requested a review from zhizhongpu April 6, 2026 22:04
@liaochris
Copy link
Copy Markdown
Collaborator Author

/run-actions-all --post

@liaochris liaochris closed this Apr 6, 2026
@liaochris liaochris reopened this Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Check Results (run details)

Check Result Time
SCons DAG 0.030s
Newlines 0.042s
EPS data 0.023s
Build log 0.035s

@github-actions

This comment was marked as resolved.

@liaochris liaochris changed the title PR for #50: Fix bugs encountered while onboarding actions PR for #150: Fix bugs encountered while onboarding actions Apr 6, 2026
@liaochris liaochris requested a review from jmshapir April 6, 2026 22:06
Copy link
Copy Markdown
Collaborator

@zhizhongpu zhizhongpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liaochris 968b1e8 made a readability tweak

@zhizhongpu
Copy link
Copy Markdown
Collaborator

@jmshapir since you're added as a reviewer, here's the rationale of this modification:

  • we discovered that in practice, we sometimes need to make exceptions for the scons dag check, so we've built an intuitive way to specify such exceptions
  • we discovered that the Actions wouldn't work in private repos without read permission, so we gave them the read permission

Comment thread .github/checks/sconscript_exceptions.py Outdated
@liaochris
Copy link
Copy Markdown
Collaborator Author

/run-actions-all --post

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Check Results (run details)

Check Result Time
SCons DAG 0.033s
Newlines 0.039s
EPS data 0.023s
Build log 0.027s

Comment thread .github/checks/sconscript_exceptions.toml Outdated
Copy link
Copy Markdown
Contributor

@jmshapir jmshapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOML works for me, just had a question about implementation/syntax.

@zhizhongpu
Copy link
Copy Markdown
Collaborator

@liaochris is there anything more to do here?

@liaochris liaochris merged commit 0c206c4 into main Apr 16, 2026
16 checks passed
@github-actions
Copy link
Copy Markdown

@liaochris Issue summary

Thanks for closing this pull.

Before leaving the pull, please be sure you have completed all the required steps in the workflow.

This includes filling in the issue summary linked at the top of this comment.

@liaochris liaochris deleted the 150-fix-bugs-in-github-actions branch April 16, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bugs in github actions

3 participants