feat(navigation): default project sidebar to Tabbed navigation#4
Merged
JOBYINC merged 1 commit intoMay 18, 2026
Merged
Conversation
All projects/users default to Tabbed navigation instead of Accordion. - workspace.py: WorkspaceUserProperties.navigation_control_preference model default ACCORDION -> TABBED (new rows) - migration 0125: AlterField (matches the model) + a data migration flipping every existing row still on 'ACCORDION' to 'TABBED' so current users get it too (the model default never touches existing rows). Reverse is a no-op — we cannot tell which rows chose ACCORDION deliberately vs. via the old silent default, so we don't blanket-revert. - navigation-preferences.ts: frontend DEFAULT_PROJECT_PREFERENCES fallback ACCORDION -> TABBED (covers users with no prefs row yet) Backend change: requires deploy + running migration 0125 on the host to take effect in production. Verified locally — migration applies clean (0124 -> 0125, no leaf conflict).
Owner
Author
|
Landed on
Migration applied to production: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
All projects/users default to Tabbed project-sidebar navigation instead of Accordion.
Why
Requested: every project should default to Tabbed navigation.
Changes
workspace.py—WorkspaceUserProperties.navigation_control_preferencemodel defaultACCORDION→TABBED(applies to newly-created rows).0125_default_tabbed_navigation—AlterField(keeps the migration state in sync with the model) + a data migration that flips every existing row still on"ACCORDION"to"TABBED", so current users get it too (the model default alone never rewrites existing rows). Reverse is a deliberate no-op: we cannot distinguish rows that chose ACCORDION intentionally from those on the old silent default, so we do not blanket-revert.navigation-preferences.ts— frontendDEFAULT_PROJECT_PREFERENCESfallbackACCORDION→TABBED(covers users with no preferences row yet; the FE uses the stored value when present, else this fallback).Tradeoff (intentional, confirmed)
The data migration overwrites the stored preference of anyone currently on ACCORDION — including anyone who may have chosen it deliberately. This was explicitly requested ("all projects default to Tabbed") and accepted.
Deploy / migration
Backend change: takes effect in production only after deploy and running migration
0125on the API/migrator host.Test plan
0124 → 0125, single leaf, no conflict), no traceback.🤖 Generated with Claude Code