Skip to content

Fixing hard-coded file path in inst/extdata#22

Open
amcim wants to merge 3 commits into
mainfrom
remotes-install
Open

Fixing hard-coded file path in inst/extdata#22
amcim wants to merge 3 commits into
mainfrom
remotes-install

Conversation

@amcim
Copy link
Copy Markdown

@amcim amcim commented May 12, 2026

Description

The included duckdb contained hard-coded file paths based on where it was created when amRdata was run. This means it would not work when put into this package's inst/extdata folder. Fixes #21

What kind of change(s) are included?

4 lines were added. After each connection
DBI::dbExecute(con, sprintf("SET file_search_path='%s'",dirname(parquet_duckdb_path)))
is run. This points DuckDB at the directory holding the parquets, so views that reference parquets by bare filename (instead of absolute path) resolve correctly.

Notes

  • Tested that the views are resolving to the same parquets and the pipeline is reading the same data after the path is made relative

  • amRdatawill have a related PR that makes sure the created duckdb has relative paths. This is what will now be included in amRml

  • This fix is relevant for the goal of having the package being installed through remotes. The permanent solution will be to stored the data on the ExperimentHub package and load it here, rather than store in inst/extdata

  • Feature (adds or updates new capabilities)

  • Bug fix (fixes an issue).

  • Enhancement (adds functionality).

  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@amcim amcim requested review from epbrenner and jananiravi May 12, 2026 06:43
@amcim amcim self-assigned this May 12, 2026
@amcim amcim changed the title Remotes install Fixing hard-coded file path in inst/extdata May 12, 2026
@jananiravi jananiravi requested a review from AbhirupaGhosh May 12, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inst/extdata data too large for Bioconductor and contains non-portable hardcoded paths

1 participant