[Bug] Results contradict in functionalities 0/1/5

[JS1936]

Describe the bug
Functionalities 0, 1, and 5 contradict in their results. 03b3aee

To reproduce
0. [Assumes project is ready to run on local device. Use branch "work2". [03b3aee]

1. Open build.gradle.
2. In build.gradle, comment out "mainClass = 'Main_API'. Uncomment "mainClass = 'Main'".
3. Open VSC terminal. Navigate to /.../PubgAPI-Java
4. In terminal, enter "./gradlew clean build".
5. In terminal, enter "./gradlew run".
6. Use console-provided example folder: "requestsDir/Shrimzy/timestamp_1750557892980/matches". When examining match results, focus on "telemetry-for-match_id_8d385883-2a04-4035-85cd-49a4f8372159".
7. Type "0" and press enter. See "#bots: 4 / 94".
8. Type "y" to allow another request.
9. Type "1" and press enter. See "#people killed by 'TOP TEN' : 30 of 99". Note 99 > 94.
10. (Still looking at results of "1"). See "MAX #kills by a single person: 7 (#people who achieved this: 2)".
11. Type "y" to allow another request.
12. Type "5" and press enter. See "adjusted #kill events: 92". 99 != 92. The number of surviving team members is (currently) unknown, so 92 deaths is feasible if 94 players is accurate and 2 players survived the game.
13. (Still looking at results of "5"). See "Kills by Winners: 1 4 4 2". Scroll up to "3 KILLS: PsychoFluffy ---------------". Scroll down to where "4 KILLS" should begin. Instead, "7 KILLS" is next. Also see "NOTE: this does not yet include the winners...". It is unclear whether this still applies. For example, winner Jeggred's name appears in the "1 KILLS" section.
14. (Still looking at results of "5"). See "7 KILLS: tayStu-nOngluv", "11 KILLS: JekLuu-nOngluv", "12 KILLS: TGLTN", "17 KILLS: Shrimzy". This does not match with functionality 1's claim that "MAX #kills by a single person: 7 (#people who achieved this: 2)". If there is an issue with only single digits being logged correctly in functionality 1, then Shrimzy with 17 kills could have been accidentally logged as having 7 kills, making it seem like there were 2 people with 7 kills in functionality 1.

Expected behavior

1. The number of players logged in functionalities 0, 1, and 5 should all match.
2. The number of kills logged in functionalities 1 and 5 should match.
3. The number of kills should not exceed (nor equal) number of players. At minimum, one player should survive.
4. The number listed in functionality 1 as "MAX #kills by a single person" should also be the highest reported number of kills in functionality 5.
5. Frequencies of kills in functionalities 1 and 5 should match.

Actual behavior

1. The number of players logged in functionalities 0, 1, and 5 do not match. 94 != GTE99 != [92, 96].
2. The number of kills logged in functionalities 1 and 5 do not match (99 and [92, 96]).
3. The number of kills (EX: 99) is not less than number of players (EX: 94).
4. The number reported in functionality 1 as "MAX #kills by a single person" (7) is not the highest reported number of kills in functionality 5 (17).
5. Frequencies of kills in functionalities 1 and 5 do not match (EX: functionality 1 reports 17 kills zero times and functionality 5 reports 17 kills once).

Priority
Users are able to use these functionalities, but at least some results are inaccurate. It is unclear which result(s) are inaccurate. Priority level: P2

Screenshots/Video

Full outputs:

• PubgAPI work2 bug screeenshot - functionality0 full output

• PubgAPI work2 bug screenshot - functionality1 full output:

• PubgAPI work2 bug screenshot - functionality5 full output (part 1 of 3):

• PubgAPI work2 bug screenshot - functionality5 full output (part 2 of 3):

• PubgAPI work2 bug screenshot - functionality5 full output (part 3 of 3):

Desktop

• OS: macOS Monterey
• Browser: Google Chrome
• Resolution: "..."
• Version: "..."

Mobile/Tablet

• Device: "..."
• OS: "..."
• Screen size: "..."
• Mobile Browser: "..."
• Version: "..."

Additional Context

• BotCounts (functionality 0) uses a Scanner, "LogMatchEnd", "LogMatchStart", and searches by accountIds. Although not printed, it stores names of players and bots.
• KillCounts (functionality 1) uses a Scanner, "LogMatchStart", and searches by "killCount".
• KillCountsJSON (functionality 5) uses JSON. It uses "LogPlayerKillV2", "victimGameResult", "stats", "killCount", "victim", "name", "LogMatchEnd, "gameResultOnFinished", and "results".
• Telemetry file location:
  /../PubgAPI-Java/requestsDir/Shrimzy/timestamp_1750557892980/matches/telemetry-for-match_id_8d385883-2a04-4035-85cd-49a4f8372159.

---

Format based on

• https://rewind.com/blog/best-practices-for-using-github-issues/
• https://gist.github.com/automationhacks/87b62440faf36d98ebbb732c372dd7c3
• https://github.com/orgs/community/discussions/147722

[JS1936]

For the given telemetry file (match_id_8d385883-2a04-4035-85cd-49a4f8372159),
the last instance of "LogGameStatePeriodic" shows some good information:

numAlivePlayers = 4 (at end of game)
numStartPlayers = 94
numStartTeams = 29

The numStartPlayers part indicates BotCounts was correct that there are 94 players (including player-bots).

[JS1936]

Cause of death could be a factor.
However, " "isSuicide": true" occurs twice in the given telemetry file (match_id_8d385883-2a04-4035-85cd-49a4f8372159). It seems to occur within "LogPlayerKillV2", except for apparently in 1 currently unidentified case.

"_T": "LogPlayerKillV2" ==> 95 occurrences
"isSuicide": true" ==> 2 occurrences
numStartPlayers = 94

[JS1936]

Functionalities 0 and 5 store participant names. Functionality 1 does not store participant names.

For a single match, try comparing the participant names from functionalities 0 and 5.
Log who exactly is present in one match and not the other (EX: bots).
It may be helpful to look at team id and see if any particular pattern exists there with names dropped.

Note: Could it also be possible that the JSON telemetry data is just incosistent?
The consistently off nature of the results across match files makes it seem like there is a factor(s) not being accounted for, though.

[JS1936]

Question: numStartPlayers should be the total number of bots + real players. Is it actually that total, or it only players?

Answer: "numStartPlayers" matches BotCounts' total of bots + players.

1. #bots:       4 / 96, “numStartPlayers": 96  | Shrimzy 6d3a…
2. #bots:       3 / 94, "numStartPlayers": 94  | Shrimzy fc5e…
3. #bots:       7 / 97, "numStartPlayers": 97  | Shrimzy 4cf1… 
4. #bots:       6 / 94, “numStartPlayers": 94  | Shrimzy 9e11…
5. #bots:       4 / 94, “numStartPlayers": 94  | Shrimzy 8d38…