Skip to content

Bunch of QOL improvements#202

Merged
fforres merged 5 commits intomainfrom
fforres/qol_updates
Jul 27, 2024
Merged

Bunch of QOL improvements#202
fforres merged 5 commits intomainfrom
fforres/qol_updates

Conversation

@fforres
Copy link
Copy Markdown
Member

@fforres fforres commented Jul 26, 2024

This PR introduces several quality of life (QOL) improvements to enhance code maintainability and efficiency.

Database Schema Adjustments:

Removed Columns:

  • max_attendees from events table. (We'll handle it with ticket amounts)
  • payment_status from user_tickets table. (it's passed through from the OC)

Eliminated redundant checks to streamline logic. We don't create by default OCs in approved status.
Defaulting on fetcher sorting logic to work with dataloaders.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.09% 10239 / 12946
🔵 Statements 79.09% 10239 / 12946
🔵 Functions 76.61% 308 / 402
🔵 Branches 82.76% 773 / 934
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/datasources/db/events.ts 100% 100% 100% 100%
src/datasources/db/userTickets.ts 100% 100% 100% 100%
src/generated/types.ts 100% 100% 100% 100%
src/schema/events/eventsFetcher.ts 100% 100% 100% 100%
src/schema/events/mutations.ts 93.21% 66.66% 100% 93.21% 103-104, 138-142, 147-150, 181-182, 203-204
src/schema/events/types.ts 96.97% 93.18% 95.83% 96.97% 100-106, 280-281
src/schema/events/tests/event.generated.ts 100% 100% 100% 100%
src/schema/purchaseOrder/actions.tsx 10.4% 100% 16.66% 10.4% 32-53, 56-139, 142-210, 212-508, 511-589
src/schema/purchaseOrder/purchaseOrderFetcher.ts 76.63% 50% 66.66% 76.63% 45-46, 49-55, 69-84
src/schema/purchaseOrder/types.ts 81.25% 100% 53.84% 81.25% 59-62, 68-69, 75-86, 92-93, 106-107, 113-114
src/schema/userTickets/mutations.ts 83.74% 73.62% 88.88% 83.74% 95-96, 139-140, 158-159, 201-202, 213-214, 225-226, 271-272, 320-321, 340-343, 387, 406-407, 417-418, 438-441, 453-454, 460-489, 499, 521-522, 542-570
src/schema/userTickets/types.ts 97.67% 83.33% 55.55% 97.67% 39-40
src/schema/userTickets/userTicketFetcher.ts 88.65% 92.3% 66.66% 88.65% 100-101, 123-136
src/schema/userTickets/tests/approvalUserTicket/approvalUserTicket.generated.ts 100% 100% 100% 100%
src/schema/userTickets/tests/cancelUserTicket/cancelUserTicket.generated.ts 100% 100% 100% 100%
src/schema/userTickets/tests/claimUserTicket/claimUserTicket.generated.ts 100% 100% 100% 100%
src/schema/userTickets/tests/redeemUserTicket/redeemUserTicket.generated.ts 100% 100% 100% 100%
src/tests/fixtures/index.ts 98.81% 80.13% 94.59% 98.81% 546, 720-724, 727, 750-751
Generated in workflow #829

@fforres fforres force-pushed the fforres/qol_updates branch 13 times, most recently from 8a17d26 to ee69ab2 Compare July 26, 2024 15:20
@fforres fforres force-pushed the fforres/qol_updates branch from ee69ab2 to 97aa641 Compare July 26, 2024 15:23
@fforres fforres changed the title sort by desc Bunch of QOL improvements Jul 26, 2024
@fforres fforres marked this pull request as ready for review July 26, 2024 15:36
@fforres fforres merged commit 1738a24 into main Jul 27, 2024
@fforres fforres deleted the fforres/qol_updates branch July 27, 2024 00:21
fforres added a commit to JSConfCL/tickets that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant