Skip to content

feat: more logs on syncPurchaseOrderPaymentStatus #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TextC0de merged 1 commit into from
Nov 4, 2024
Merged

feat: more logs on syncPurchaseOrderPaymentStatus #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/datasources/mercadopago/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const getPaymentStatusFromMercadoPago = (
throw new Error(`Unknown payment status: ${theStatus}`);
};

const getPurchasOrderStatusFromMercadoPago = (
const getPurchaseOrderStatusFromMercadoPago = (
mercadoPagoStatus: PaymentResponse["status"],
): (typeof purchaseOrderStatusEnum)[number] => {
const theStatus = mercadoPagoStatus?.toLowerCase();
Expand Down Expand Up @@ -178,9 +178,11 @@ export const getMercadoPagoPreference = async ({
export const getMercadoPagoPayment = async ({
purchaseOrderId,
getMercadoPagoClient,
logger,
}: {
purchaseOrderId: string;
getMercadoPagoClient: MercadoPagoFetch;
logger: Logger;
}) => {
const result = await getMercadoPagoClient<{ results: PaymentResponse[] }>({
url: `/v1/payments/search?external_reference=${purchaseOrderId}`,
Expand All @@ -191,8 +193,18 @@ export const getMercadoPagoPayment = async ({
? result.results[result.results.length - 1]
: null;

if (lastPaymentHistory) {
logger.info(`Payment found for PO with ID: ${purchaseOrderId}`, {
status: lastPaymentHistory.status,
});
} else {
logger.info(`No payment history found for PO with ID: ${purchaseOrderId}`, {
response: result,
});
}

return {
paymentStatus: getPaymentStatusFromMercadoPago(lastPaymentHistory?.status),
status: getPurchasOrderStatusFromMercadoPago(lastPaymentHistory?.status),
status: getPurchaseOrderStatusFromMercadoPago(lastPaymentHistory?.status),
};
};
10 changes: 10 additions & 0 deletions src/datasources/stripe/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
PurchaseOrderStatus,
} from "~/datasources/db/schema";
import { someMinutesIntoTheFuture } from "~/datasources/helpers";
import { Logger } from "~/logging";

const getPaymentStatusFromStripeSession = (
stripeStatus: Stripe.Response<Stripe.Checkout.Session>["payment_status"],
Expand Down Expand Up @@ -225,17 +226,26 @@ export const createStripePayment = async ({
export const getStripePaymentStatus = async ({
paymentId,
getStripeClient,
logger,
}: {
paymentId: string;
getStripeClient: () => Stripe;
logger: Logger;
}) => {
const stripeClient = getStripeClient();
const payment = await stripeClient.checkout.sessions.retrieve(paymentId);

if (!payment) {
logger.error(`Payment not found for id: ${paymentId}`);

throw new Error(`Payment not found for id: ${paymentId}`);
}

logger.info(`Payment found for id: ${paymentId}`, {
payment_status: payment.payment_status,
status: payment.status,
});

return {
paymentStatus: getPaymentStatusFromStripeSession(payment.payment_status),
status: getPurchaseOrderStatusFromStripeSession(payment.status),
Expand Down
7 changes: 7 additions & 0 deletions src/schema/purchaseOrder/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,7 @@ export const syncPurchaseOrderPaymentStatus = async ({
const stripeStatus = await getStripePaymentStatus({
paymentId: paymentPlatformReferenceID,
getStripeClient: GET_STRIPE_CLIENT,
logger,
});

poPaymentStatus = stripeStatus.paymentStatus;
Expand All @@ -1031,13 +1032,19 @@ export const syncPurchaseOrderPaymentStatus = async ({
const mercadoPagoStatus = await getMercadoPagoPayment({
purchaseOrderId: purchaseOrder.id,
getMercadoPagoClient: GET_MERCADOPAGO_CLIENT,
logger,
});

poPaymentStatus = mercadoPagoStatus.paymentStatus;

poStatus = mercadoPagoStatus.status ?? poStatus;
}

logger.info(`New purchase order ${purchaseOrderId} status`, {
poPaymentStatus,
poStatus,
});

if (
poPaymentStatus !== purchaseOrder.purchaseOrderPaymentStatus ||
poStatus !== purchaseOrder.status
Expand Down