-
Notifications
You must be signed in to change notification settings - Fork 23
Add WebdriverIO application #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Hello @christian-bromann! Thank you for the application. I will make sure the TAC is aware and begins reviewing ASAP. We will be in touch soon. |
|
Hey @christian-bromann, the TAC is reviewing this now and will let you know soon! |
| * Gitter support Channel: ~1800 user (https://gitter.im/webdriverio/webdriverio) | ||
| * Most active authors | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a definition for "active authors"? The graph seems to indicate there were about 150 active authors in the past year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmethvin with active authors I meant people who contributed in the past year. Obviously some of them are one time contributors however some also proposed PRs multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-bromann How/where was that data collected regarding contributors? I don't see 150 contributors in the graphs that GitHub provides but maybe your data crosses multiple repos, counts issue creators, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmethvin it was generated using git source metrics by someone who did a full e2e tooling comparison on his blog: https://mo.github.io/2017/07/20/javascript-e2e-integration-testing.html. I grabbed the stats from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source of graph generation is https://github.com/mo/git-source-metrics-web-e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I looked at the repo it didn't look that high but i just pulled the repo and did a $ git shortlog 9125db7..HEAD -n -s which came pretty close to the same number. So we're good 👍
|
|
||
| The goal of WebdriverIO is to provide developers a framework to run e2e tests on their desktop and mobile applications. It tries to simplify the test process by taking care of common pitfalls in e2e testing. It is not made to run any kind of other tests like unit or API tests. It only speaks the Webdriver protocol. However services and add ons may provide additional functionalities. | ||
|
|
||
| # Current governance process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to add detailed government process to be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yichoi what kind of details are you missing? I'ld be happy to provide more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-bromann If you wanted to add some sort of intended governance process here that would be great but we had an internal discussion and clarified that if that is unknown at the time and all you know is what you do now, that is fine. The mentorship process is meant to develop and implement that plan so if you don't have anything to add here, that is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that is unknown at the time and all you know is what you do now, that is fine.
This is the case. There is no defined governance process yet. I would be happy to develop one as part of the JSF mentorship
dmethvin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@christian-bromann Congratulations! 🎉 Can you send an email to projects@js.foundation for next steps? Thanks! |
Please let me know if any points are not clear or should be extended.
Thanks!