Initial structure #1
Conversation
JSGette
force-pushed
the
initial_structure
branch
from
fd9258c to
fa0d8ea
Compare
src/main/kotlin/Main.kt
Outdated
| } | ||
|
|
||
| fun calculateExecHash(str: String): String { | ||
| return MessageDigest.getInstance("SHA-256").digest(str.toByteArray()) |
There was a problem hiding this comment.
You should save the the MessageDigest instance instead of getting it each time.
src/main/kotlin/MergedSpawnExec.kt
Outdated
| class MergedSpawnExec( | ||
| val listedOutputs: List<String>, | ||
| val aEnvVars: Map<String, String>?, | ||
| val aInputs: Map<String, Digest>? | ||
| ) { |
There was a problem hiding this comment.
Shouldn't this be just a class with: listedOutputs, envVars and inputs? Why do you put in two versions? Just store them in a separate list in main, e.g: spawnSpecsA and mergedSpawnSpecs.
There was a problem hiding this comment.
Also if you had to keep this structure (which I don't recommend), you could have this as a data class:
data class MergedSpawnSpec(
val listedOutputs: List<String>,
val aEnvVars: Map<String, String>?,
val aInputs: Map<String, Digest>?,
var bEnvVars: Map<String, String> = HashMap(),
var bInputs: Map<String, Digest> = HashMap(),
var presentInBothExecs: Boolean = false,
)
There was a problem hiding this comment.
listedOutputs are the same for both executions but inputs and envVars may be different. So I need to save both to compare them later on or only save those that are different in MergedSpawnExec instance
src/main/kotlin/Main.kt
Outdated
| return Pair(execHash, spawnExec) | ||
| } | ||
|
|
||
| fun calculateExecHash(str: String): String { |
There was a problem hiding this comment.
str is used in both the function name as well as in the lambda, so the function variable is shadowed. Better to have different names, because this could lead to confusing code.
| MergedSpawnExec( | ||
| spawnExec.second.listedOutputsList, | ||
| spawnExec.second.environmentVariablesList.associate { it.name to it.value }, | ||
| spawnExec.second.inputsList.associate { it.path to it.digest } | ||
| ) |
There was a problem hiding this comment.
Looks like this should be one class, and for pathB you want some other class.
No description provided.