Skip to content

"type" reference in Relationship #689

@tiagopog

Description

@tiagopog

Hi there,

I'm probably missing something, so I would like to know if there is any particular reason to grab the relation's type by:

@type = class_name.underscore.pluralize.to_sym

Instead of something like this:

@type = resource_klass._type.to_sym

IMHO it would make more sense to grab it from resource_klass than class_name in order to avoid incoherences such as:

Having this value for type at relationship member:

screen shot 2016-04-26 at 3 42 29 pm

And this one at included member:

screen shot 2016-04-26 at 3 45 29 pm

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions