Skip to content

require bundler in bug_report_templates_test#1014

Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
senid231:1013-fix-bug-report-template-execution-through-rake-default
May 4, 2017
Merged

require bundler in bug_report_templates_test#1014
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
senid231:1013-fix-bug-report-template-execution-through-rake-default

Conversation

@senid231
Copy link
Copy Markdown
Contributor

fix #1013
fails when rake runs without bundle exec

@Aryk
Copy link
Copy Markdown

Aryk commented Mar 27, 2017

Does this prevent all the output that happens when you require 'bundler'? When I put "require 'bundler'" i got all this output, but could just be me:

screen shot 2017-03-27 at 12 01 43 am

@senid231
Copy link
Copy Markdown
Contributor Author

senid231 commented Apr 4, 2017

add optional log silencer

@senid231
Copy link
Copy Markdown
Contributor Author

senid231 commented Apr 4, 2017

@lgebhardt take a look, please

@lgebhardt
Copy link
Copy Markdown
Contributor

@senid231 This looks fine, though I'd be just as happy excluding the test from being run. That could be done by removing assert_bug_report 'rails_5_master.rb' from test/bug_report_templates_test.rb.

Do you see any reason to run the bug_report_templates as part of standard testing?

@senid231
Copy link
Copy Markdown
Contributor Author

senid231 commented Apr 12, 2017

I think we need to be sure that bug report template works for master. But adding it to test suite looks little ugly. It will be better to create separate rake task for it and run after test suite.
@lgebhardt do you agree with this?

@lgebhardt
Copy link
Copy Markdown
Contributor

@senid231 That sounds right.

@senid231 senid231 force-pushed the 1013-fix-bug-report-template-execution-through-rake-default branch from 9c59a3e to 2efc54b Compare April 20, 2017 11:00
… default task

add rake task test:bug_report_template:rails_5
silence bug_report_templates/rails_5_master.rb when running from rake
remove bug_report_templates_test from test suite
@senid231 senid231 force-pushed the 1013-fix-bug-report-template-execution-through-rake-default branch from 2efc54b to ec3f673 Compare April 20, 2017 11:02
@senid231
Copy link
Copy Markdown
Contributor Author

reworked and rebased
rake task for bug report template added and used on default rake

@lgebhardt, please take a look

@lgebhardt lgebhardt merged commit ff43ac0 into JSONAPI-Resources:master May 4, 2017
@lgebhardt
Copy link
Copy Markdown
Contributor

@senid231 Thanks for cleaning that up. I've merged it as is, but I do wonder if we should exclude the new task from the default rake. But we can do that later if it causes problems.

@senid231 senid231 deleted the 1013-fix-bug-report-template-execution-through-rake-default branch May 4, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BugReportTemplatesTest failure

3 participants