Rework apply_filter(s) to allow callables to be called for relationship filters#1033
Merged
Rework apply_filter(s) to allow callables to be called for relationship filters#1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that callables on filters on relationships were not being called. This should fix that.
Moves the filtering logic to
apply_filterfromapply_filters.Modifies the includes in the options hash instead of applying the includes twice.
One possible change we could make is to modify the includes if an
applycallable is provide. This would push handling the included relationship onto the callable author, which might create problems for authors since it's not obvious it must be done.