Do not verify_filters in the RequestParser#1111
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from Dec 10, 2017
Merged
Do not verify_filters in the RequestParser#1111lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
Conversation
A prior change to allow filters to be passed to related resources was incompletely backported from `master` to the `release-0-9` branch (see: 3a691b2). This completes the backport, which moves the `verify_filters` from the `RequestParser` down to the `Processor`. When `verify_filters` happens in both places, we end up running `verify_filter` twice for each filter, which can result in the filter values being wrapped in nested Arrays. fixes JSONAPI-Resources#1110
Author
|
These failures seem to be a problem in minitest rather than with any changes I made. Thoughts? |
Author
|
Any thoughts on this PR? It would be nice to get the |
Author
|
@lgebhardt Sorry to @ you on this one, but any chance of merging this into the |
Contributor
|
@stevenharman Thanks, and sorry for the delay. Thanks for pointing out the errors in the tests, though I must admit I missed that when i first reviewed this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prior change to allow filters to be passed to related resources was incompletely backported from
masterto therelease-0-9branch (see: 3a691b2). This completes the backport, which moves theverify_filtersfrom theRequestParserdown to theProcessor. Whenverify_filtershappens in both places, we end up runningverify_filtertwice for each filter, which can result in the filter values being wrapped in nested Arrays.fixes #1110