Works around primary key being cast due to pluck bug#1159
Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom Jul 10, 2018
Merged
Works around primary key being cast due to pluck bug#1159lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
Conversation
lgebhardt
requested changes
Jul 3, 2018
Contributor
Author
|
Can do. It may take me a day or so but it'll definitely get done. Thanks! |
Contributor
Author
|
Looks like it's failing because I added a Most likely related to rails/rails#24857 Workaround is to set self.primary_key = "id" on the resource. I've pushed a fix (note my commenting out of the final assert_equal in my new test) |
Contributor
|
@butchmarshall Thanks for tracking that down and fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
A unit test has been included with this pull request which reproduces the issue described.
Reviewer Checklist:
This fixes issue #1156 and provides a complete set of fixes for pull request #986.