Skip to content

Introduce Resource.retrieve_records#1189

Merged
dgeb merged 1 commit intomasterfrom
retrieve_records
Oct 31, 2018
Merged

Introduce Resource.retrieve_records#1189
dgeb merged 1 commit intomasterfrom
retrieve_records

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

Allows the processor to retrieve records without further filtering,
which will have taken place earlier in the find_fragments and
find_related_fragments. This fixes issues where records has been
overridden and interferes with getting included
records (and already filtered by the find fragment step).

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Allows the processor to retrieve records without further filtering,
which will have taken place earlier in the `find_fragments` and
`find_related_fragments`. This fixes issues where `records` has been
overridden and interferes with getting included
records (and already filtered by the find fragment step).
@dgeb dgeb merged commit b52ef84 into master Oct 31, 2018
@dgeb dgeb deleted the retrieve_records branch October 31, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants