Remove unused :include IncludeDirectives key#1226
Closed
Conversation
da51ea6 to
e009a3c
Compare
:include IncludeDirectives key:include IncludeDirectives key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:includeoption for IncludeDirectives is no longer being used.This was originally used for allowing included relationships that skipped intermediate relationships, as well as for not including resources when intermediate relationships were needed for join tracking. Both these uses are no longer handled by IncludeDirectives.
The IncludeDirectives could be further simplified by removing the
:include_relatedintermediate hash now that:includeis being removed. However this does remove the option of adding additional directions per include level (which is how it was being used in earlier versions). For now I think we should leave that option openAll Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: