Skip to content

Remove unused :include IncludeDirectives key#1226

Closed
lgebhardt wants to merge 1 commit intomasterfrom
remove_include_include_directive_option
Closed

Remove unused :include IncludeDirectives key#1226
lgebhardt wants to merge 1 commit intomasterfrom
remove_include_include_directive_option

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

@lgebhardt lgebhardt commented Feb 27, 2019

The :include option for IncludeDirectives is no longer being used.

This was originally used for allowing included relationships that skipped intermediate relationships, as well as for not including resources when intermediate relationships were needed for join tracking. Both these uses are no longer handled by IncludeDirectives.

The IncludeDirectives could be further simplified by removing the :include_related intermediate hash now that :include is being removed. However this does remove the option of adding additional directions per include level (which is how it was being used in earlier versions). For now I think we should leave that option open

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt force-pushed the remove_include_include_directive_option branch from da51ea6 to e009a3c Compare March 15, 2019 17:23
@lgebhardt lgebhardt changed the title [WIP] Remove unused :include IncludeDirectives key Remove unused :include IncludeDirectives key Mar 15, 2019
@lgebhardt lgebhardt marked this pull request as ready for review March 15, 2019 17:59
@lgebhardt lgebhardt closed this in 5d18849 Mar 22, 2019
@lgebhardt lgebhardt deleted the remove_include_include_directive_option branch March 22, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant