Add specialized records methods, and find_to_populate_by_keys#1228
Closed
Add specialized records methods, and find_to_populate_by_keys#1228
records methods, and find_to_populate_by_keys#1228Conversation
44d6062 to
17a4296
Compare
Specialized records methods allow the system to avoid duplicating expensive permission checks for records that have already been found. This is needed because of the new multiphase approach building up the result set.
17a4296 to
0c89471
Compare
records methods, and find_to_populate_by_keysrecords methods, and find_to_populate_by_keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specialized records methods allow the system to avoid duplicating
expensive permission checks for records that have already been found.
This is needed because of the new multiphase approach building up the
result set.
WIP for testing and wording review. I think this needs tests to ensure correct usage, but I'm not sure of the best way to handle this.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: