Skip to content

Add specialized records methods, and find_to_populate_by_keys#1228

Closed
lgebhardt wants to merge 1 commit intomasterfrom
specialized_records_methods
Closed

Add specialized records methods, and find_to_populate_by_keys#1228
lgebhardt wants to merge 1 commit intomasterfrom
specialized_records_methods

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

Specialized records methods allow the system to avoid duplicating
expensive permission checks for records that have already been found.
This is needed because of the new multiphase approach building up the
result set.

WIP for testing and wording review. I think this needs tests to ensure correct usage, but I'm not sure of the best way to handle this.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt force-pushed the specialized_records_methods branch from 44d6062 to 17a4296 Compare March 4, 2019 12:10
Specialized records methods allow the system to avoid duplicating
expensive permission checks for records that have already been found.
This is needed because of the new multiphase approach building up the
result set.
@lgebhardt lgebhardt force-pushed the specialized_records_methods branch from 17a4296 to 0c89471 Compare March 11, 2019 21:25
@lgebhardt lgebhardt marked this pull request as ready for review March 11, 2019 21:44
@lgebhardt lgebhardt changed the title [WIP] Add specialized records methods, and find_to_populate_by_keys Add specialized records methods, and find_to_populate_by_keys Mar 11, 2019
@lgebhardt lgebhardt closed this in d87cd2d Mar 15, 2019
@lgebhardt lgebhardt deleted the specialized_records_methods branch March 15, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant