Allow setting of the resource finder on a per resource basis#1230
Closed
Allow setting of the resource finder on a per resource basis#1230
Conversation
scottgonzalez
requested changes
Mar 14, 2019
94b3a5e to
4ff090e
Compare
Loads resource finder when found to be missing. This delayed loading enables the resource to set a resource finder that is used in place of the default. Removes the abstract methods from resource. These may vary based on the processor.
4ff090e to
fd5f18b
Compare
scottgonzalez
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets us closer to supporting alternate resource finders. This should work with multiple resource finders as long as relationships do not span the different data stores.
I wanted to keep the resource finders as mix-ins to allow existing code to override the
recordsand other methods. In order to support a default resource finder and allow setting this with a method in the resource class definition the mix-in needed to delay loading. This was accomplished withmethod_missingto load the resource finder if it isn't loaded.All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: