Unscope includes when plucking linkage data#1243
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from Jun 4, 2019
Merged
Unscope includes when plucking linkage data#1243lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
Conversation
st0012
changed the title
scottgonzalez
approved these changes
Apr 10, 2019
It's very common to eager load data in JR. But if we keep includes values when plucking for linkage data, it can make the query unnecessarily expensive. Let's use Post model for example: If we directly pluck all posts' `created_at` column, the query would be very simple ```sql SELECT "posts"."created_at" FROM "posts" ``` But if we keep includes values in the previous relation object, like ```ruby Post.includes(:author).pluck(:created_at) ``` It generates unnecessarily complicated query ```sql SELECT "posts"."created_at" FROM "posts" LEFT OUTER JOIN "people" ON "people"."id" = "posts"."author_id" ``` So we should always unscope includes when we only want to pluck linkage data.
st0012
changed the title
Contributor
Author
|
@lgebhardt would you mind if I introduce this new gem https://github.com/brigade/db-query-matchers to test the query differnces? |
Contributor
|
@st0012 that seems fine to me |
Contributor
|
@st0012 Thanks! |
Contributor
Author
|
@lgebhardt sorry that I forgot about updating this 😓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1242
All Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: