Build Links with strings, track route setup on resource and relationships#1263
Merged
Build Links with strings, track route setup on resource and relationships#1263
Conversation
…hips Revert building links with 'url_helpers' for performance reasons
e971cfe to
3a75833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert building links with 'url_helpers' for performance reasons
Now tracking whether routes have been setup for resources and relationships in the respective objects. This allows for the efficiency of string based link generation as well as warning when a route has not been setup. This should restore the performance we lost with the
url_helpers.Also reworked way the LinkBuilder handles Engines.
This is the same basic changes as #1262
Closes #1259
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: