Skip to content

Remove extra assignments#1270

Merged
lgebhardt merged 2 commits intomasterfrom
cleanup
Jul 18, 2019
Merged

Remove extra assignments#1270
lgebhardt merged 2 commits intomasterfrom
cleanup

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

This fixes two issues with extra assignments. Combined these were adding a lot of unneeded memory allocations.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt merged commit cf210f3 into master Jul 18, 2019
@lgebhardt lgebhardt deleted the cleanup branch September 16, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants