Warn on performance issues: non-normalized result set#1271
Merged
Conversation
d42bc6f to
8424271
Compare
dgeb
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the removal of the
distinctcall in #1225 it's now possible for a user who overridesrecordsand joins in a has_many relationship to experience extremely slow responses due to non-normalized data. Usingdistinctwas hiding this database access faux pas.This PR adds detection based on the assumption that every row in the result set should translate into a unique resource fragment. If the counts do not match a warning is given in the logs. This warning can be controlled with a new configuration option,
warn_on_performance_issues.It's planned that future performance issue checks will be controlled with the same configuration setting.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: