Skip to content

Fix typo in config_description hash key#1274

Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
tobias-bischoff:patch-1
Sep 16, 2019
Merged

Fix typo in config_description hash key#1274
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
tobias-bischoff:patch-1

Conversation

@tobias-bischoff
Copy link
Copy Markdown
Contributor

Typo “seriserialization_options” → “serialization_options”. I couldn't find any references to this misspelt key in the current codebase, neither any GitHub search result besides forks of jsonapi-resources 😄 So I presume it's safe to correct it.

The only usage of the affected config_description method I found ends up using the keys as part of a cache key, which won't be affected either.

closes #1273

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

lgebhardt and others added 2 commits September 16, 2019 13:50
Typo “seriserialization_options” → “serialization_options”. I couldn't find any references to this misspelt key in the current codebase, neither any GitHub search result besides forks of jsonapi-resources 😄 So I presume it's safe to correct it.

The only usage of the affected `config_description` method I found ends up using the keys as [part of a cache key](https://github.com/cerebris/jsonapi-resources/blob/d87cd2d2e80ab7660081c32db2303f196860b060/lib/jsonapi/resource_set.rb#L28), which won't be affected either.
@lgebhardt lgebhardt merged commit 9e18e02 into JSONAPI-Resources:master Sep 16, 2019
@lgebhardt
Copy link
Copy Markdown
Contributor

@tobias-grasse Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in JSONAPI::ResourceSerializer.config_description hash key

2 participants