Fix typo in config_description hash key#1274
Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom Sep 16, 2019
tobias-bischoff:patch-1
Merged
Fix typo in config_description hash key#1274lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom tobias-bischoff:patch-1
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
tobias-bischoff:patch-1
Conversation
Typo “seriserialization_options” → “serialization_options”. I couldn't find any references to this misspelt key in the current codebase, neither any GitHub search result besides forks of jsonapi-resources 😄 So I presume it's safe to correct it. The only usage of the affected `config_description` method I found ends up using the keys as [part of a cache key](https://github.com/cerebris/jsonapi-resources/blob/d87cd2d2e80ab7660081c32db2303f196860b060/lib/jsonapi/resource_set.rb#L28), which won't be affected either.
Contributor
|
@tobias-grasse Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo “seriserialization_options” → “serialization_options”. I couldn't find any references to this misspelt key in the current codebase, neither any GitHub search result besides forks of jsonapi-resources 😄 So I presume it's safe to correct it.
The only usage of the affected
config_descriptionmethod I found ends up using the keys as part of a cache key, which won't be affected either.closes #1273
All Submissions:
Bug fixes and Changes to Core Features:
Reviewer Checklist: