Skip to content

require ruby 2.3 as minimum version#1279

Closed
lsylvester wants to merge 2 commits intoJSONAPI-Resources:masterfrom
lsylvester:ruby-version-requirement
Closed

require ruby 2.3 as minimum version#1279
lsylvester wants to merge 2 commits intoJSONAPI-Resources:masterfrom
lsylvester:ruby-version-requirement

Conversation

@lsylvester
Copy link
Copy Markdown
Contributor

In https://github.com/cerebris/jsonapi-resources/pull/1188, support for ruby2.1 and 2.2 in the CI was removed.

When trying to use this gem with ruby 2.1, I am getting the following error:

jsonapi-resources-0.9.10/lib/jsonapi/resource_serializer.rb:100: syntax error, unexpected ':', expecting => (SyntaxError)
      rel_hash = { 'data': data }

This PR updates the required ruby version so that jsonapi-resources can't be installed on ruby versions that is does not support.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lsylvester lsylvester force-pushed the ruby-version-requirement branch from 553d574 to 3d9c073 Compare August 20, 2019 05:31
@lsylvester
Copy link
Copy Markdown
Contributor Author

Bundler 2 was being installed by default for some ruby versions, which caused bundle install to fail as bundler didn't match what was in the gem spec (this looks like it cause failures on other PRs as well).

I have updated the travis.yml to uninstall bundler 2 and install bundler 1.X - as it is required for rails 4.2 support.

@lgebhardt
Copy link
Copy Markdown
Contributor

@lsylvester Thanks! I ended up fixing the bundler issue in an earlier PR so I just add the ruby 2.3 minimum version commit. The way I handled bundler isn't exactly the same, but it seems to work. If you think we still need to uninstall versions let's make a new PR for that.

@lgebhardt lgebhardt closed this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants