require ruby 2.3 as minimum version#1279
Closed
lsylvester wants to merge 2 commits intoJSONAPI-Resources:masterfrom
Closed
require ruby 2.3 as minimum version#1279lsylvester wants to merge 2 commits intoJSONAPI-Resources:masterfrom
lsylvester wants to merge 2 commits intoJSONAPI-Resources:masterfrom
Conversation
553d574 to
3d9c073
Compare
Contributor
Author
|
Bundler 2 was being installed by default for some ruby versions, which caused I have updated the travis.yml to uninstall bundler 2 and install bundler 1.X - as it is required for rails 4.2 support. |
Contributor
|
@lsylvester Thanks! I ended up fixing the bundler issue in an earlier PR so I just add the ruby 2.3 minimum version commit. The way I handled bundler isn't exactly the same, but it seems to work. If you think we still need to uninstall versions let's make a new PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/cerebris/jsonapi-resources/pull/1188, support for ruby2.1 and 2.2 in the CI was removed.
When trying to use this gem with ruby 2.1, I am getting the following error:
This PR updates the required ruby version so that jsonapi-resources can't be installed on ruby versions that is does not support.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: