Return a 404 response when no record is found#1295
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Dec 10, 2019
Merged
Conversation
The JSON API specification says: > A server MUST respond with `404 Not Found` when processing a request to fetch a single resource that does not exist At the moment JSON API Resources returns a 200, with an empty data object.
Collaborator
|
@lgebhardt Is there a reason that |
Contributor
|
@scottgonzalez Using |
lgebhardt
approved these changes
Nov 16, 2019
Contributor
lgebhardt
left a comment
There was a problem hiding this comment.
@MarcelEeken Thanks, this looks good to me.
Contributor
Author
|
@lgebhardt Thank you for approving, do you have any timeline when you expect this to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON API specification says:
At the moment JSON API Resources returns a 200, with an empty data
object.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: