Skip to content

[Resolves #1299] Fix missing scoped association#1300

Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
rpbaltazar:1299-include-scoped-relationships
Dec 10, 2019
Merged

[Resolves #1299] Fix missing scoped association#1300
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
rpbaltazar:1299-include-scoped-relationships

Conversation

@rpbaltazar
Copy link
Copy Markdown

@rpbaltazar rpbaltazar commented Dec 6, 2019

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@rpbaltazar rpbaltazar changed the title [Hotfix] Fix missing scoped association [Resolves #1299] Fix missing scoped association Dec 6, 2019
@rpbaltazar rpbaltazar force-pushed the 1299-include-scoped-relationships branch from ef5b1d0 to 0280f70 Compare December 6, 2019 07:39
Copy link
Copy Markdown
Contributor

@lgebhardt lgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lgebhardt lgebhardt merged commit e520fbb into JSONAPI-Resources:release-0-9 Dec 10, 2019
@rpbaltazar
Copy link
Copy Markdown
Author

@lgebhardt any planned release for the 0.9.x ?

@lgebhardt lgebhardt mentioned this pull request Dec 11, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants