Lookup polymorphic type from the column before fetching the record#1326
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from Jan 25, 2021
Merged
Conversation
Currently, `Relationship#type_for_source` looks up polymorphic source's type by: 1. Fetching its associated record. 2. Calling `.class._type` on that record. This approach is inefficient because usually, a polymorphic record (the `source`) has `_type` and `_id` columns. And the `_type` column's value will be the polymorphic relationship record's type. So this PR makes `type_for_source` check the type value from column before fetching the associated record.
Contributor
|
@st0012 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Relationship#type_for_sourcelooks up associated record's type by:.class._typeon that record.This approach is inefficient because usually, a polymorphic record (the
source) has_typeand_idcolumns. And the_typecolumn's value will be the polymorphic relationship record's type.So this PR makes
type_for_sourcecheck the type value from column before fetching the associated record.All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: