Skip to content

Rework request#1330

Merged
lgebhardt merged 3 commits intomasterfrom
rework_request
Sep 23, 2020
Merged

Rework request#1330
lgebhardt merged 3 commits intomasterfrom
rework_request

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

Renames JSONAPI::RequestParser to JSONAPI::Request and provides access to this in the controller by a class variable. This will provide access to the request for inspection and manipulation in the process_operations callbacks.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Copy link
Copy Markdown
Contributor

@dgeb dgeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the naming refactor as well as the switch to setting up an array of @operations.

@lgebhardt lgebhardt merged commit 7a2de30 into master Sep 23, 2020
@lgebhardt lgebhardt deleted the rework_request branch September 23, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants