Merged
Conversation
…t sql statement order
…r operations callbacks
dgeb
approved these changes
Sep 23, 2020
Contributor
dgeb
left a comment
There was a problem hiding this comment.
Looks good! I like the naming refactor as well as the switch to setting up an array of @operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames JSONAPI::RequestParser to JSONAPI::Request and provides access to this in the controller by a class variable. This will provide access to the request for inspection and manipulation in the process_operations callbacks.
All Submissions:
New Feature Submissions:
Test Plan:
Reviewer Checklist: