Skip to content

URI.unescape is obsolete#1340

Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
bf4:patch-1
Jan 7, 2021
Merged

URI.unescape is obsolete#1340
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
bf4:patch-1

Conversation

@bf4
Copy link
Copy Markdown
Collaborator

@bf4 bf4 commented Dec 1, 2020

It's throwing warnings on Ruby 2.7.2

Closes https://github.com/cerebris/jsonapi-resources/issues/1339

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

It's throwing warnings on Ruby 2.7.2

per rails/rails#39733 this change should be fine
@tommy-russoniello
Copy link
Copy Markdown
Collaborator

Duplicate of gh-1335

@tommy-russoniello tommy-russoniello marked this as a duplicate of #1335 Dec 1, 2020
@bf4 bf4 mentioned this pull request Dec 1, 2020
12 tasks
@lgebhardt lgebhardt merged commit 1dd5f18 into JSONAPI-Resources:release-0-9 Jan 7, 2021
@bf4 bf4 deleted the patch-1 branch January 9, 2021 00:40
@bf4 bf4 mentioned this pull request Feb 1, 2021
7 tasks
hauleth referenced this pull request in hauleth/jsonapi-resources Nov 10, 2021
This is reapplication of cerebris/jsonapi-resources#1340
hauleth referenced this pull request in hauleth/jsonapi-resources Nov 10, 2021
This is reapplication of cerebris/jsonapi-resources#1340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants