Use resource_class of relationship to apply filters, etc.#224
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom May 29, 2015
Merged
Conversation
lgebhardt
added a commit
that referenced
this pull request
May 29, 2015
Use resource_class of relationship to apply filters, etc.
Contributor
|
Good catch! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one took me a while to track down! 🎉
The source resource class was being used to apply filters, sorting, and pagination for relationships. So, if
apply_filterset al were implemented in the resource class for the relationship, they weren't being used. That was causing incorrect results to be returned by theget_related_resourcescontroller method.