Conversation
|
@john-griffin I updated your PR (#214) with the changes in the latest master. Could you please take a look at the changes and confirm they will work with your cursor based approach? Also, if you wouldn't mind I'd love to get cursor based pagination into the project. If you could create a PR with that it would be appreciated very much. |
|
@lgebhardt thanks for updating the PR - this gets my cursor pagination tests passing. I'll for sure get a PR up for it. It's a little specific to our app right now so I might spend sometime making it more generic. 👍 |
|
@john-griffin Thanks for confirming. I'll merge once Travis finishes. |
To build paginators that rely on sort order (e.g. cursor pagination) the sort order requested must be known when applying pagination. This adds an additional argument to Paginator#apply to supply the current sort order and hooks it in through the resource finders.
|
@john-griffin I had to rebase again due to another PR. If you have a minute could you confirm that the code still works? |
|
@lgebhardt yep still good here |
This updates #214 with the new changes in master.
To build paginators that rely on sort order (e.g. cursor pagination) the
sort order requested must be known when applying pagination. This adds
an additional argument to Paginator#apply to supply the current sort
order and hooks it in through the resource finders.