Skip to content

Remove unneeded relationship_data method #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgebhardt merged 1 commit into from
May 30, 2015
Merged

Remove unneeded relationship_data method #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions lib/jsonapi/resource_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def object_hash(source, include_directives)
attributes = attribute_hash(source)
obj_hash['attributes'] = attributes unless attributes.empty?

relationships = relationships_hash(source, include_directives)
relationships = relationship_data(source, include_directives)
obj_hash['relationships'] = relationships unless relationships.nil? || relationships.empty?

return obj_hash
Expand All @@ -133,18 +133,6 @@ def attribute_hash(source)
end
end

def relationships_hash(source, include_directives)
rel_hash = {}

links = relationship_links(source)
rel_hash['links'] = links unless links.empty?

data = relationship_data(source, include_directives)
rel_hash['data'] = data unless data.empty?

# links_hash(source, include_directives)
end

def relationship_data(source, include_directives)
associations = source.class._associations
requested = requested_fields(source.class._type)
Expand Down