Provide options context to apply_filter#238
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Jun 5, 2015
Merged
Provide options context to apply_filter#238lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom
Conversation
Overriding apply_filter is the recommended way to implement custom filters. However if filtering relies on the context (e.g. current_user) it was not possible to implement the custom filter. This passes the options context to the apply_filter method so it is available when overriding in a resource.
john-griffin
force-pushed
the
filter-context
branch
from
34ef367 to
4f494a4
Compare
Contributor
Author
|
Tests passing now. |
Collaborator
|
Good catch. |
lgebhardt
added a commit
that referenced
this pull request
Jun 5, 2015
Provide options context to apply_filter
Contributor
|
Good catch. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overriding
apply_filteris the recommended way to implement customfilters. However if filtering relies on the context (e.g.
current_user)it was not possible to implement the custom filter. This passes the
options context to the
apply_filtermethod so it is available whenoverriding in a resource.