Allow passing options to attributes the same way as to attribute#266
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Jun 19, 2015
Merged
Conversation
lgebhardt
added a commit
that referenced
this pull request
Jun 19, 2015
Allow passing options to attributes the same way as to attribute
Contributor
|
Great addition. Thanks! |
Contributor
|
I am passing..
with JSONAPI::Resource defining
and get: |
Contributor
|
@butchmarshall it's because class TimestampValueFormatter < JSONAPI::ValueFormatter
class << self
def format(raw_value)
raw_value.to_i unless raw_value.nil?
end
def unformat(raw_value)
Time.at(raw_value) unless raw_value.nil?
end
end
endbut I agree that error @lgebhardt what do you think we should do in this case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like this