Meta: page_count#622
Merged
lgebhardt merged 8 commits intoJSONAPI-Resources:masterfrom May 4, 2016
Merged
Conversation
Contributor
Author
|
@lgebhardt or @barelyknown is there anything else I can do here? |
Contributor
|
@utilityboy Sorry for the very late response. I swear I commented about this back in March, but I probably forgot to hit the comment button. Anyway, it's missing tests that cover the page count in the find operation. You can see coverage with: COVERAGE=true bundle exec rake testIn addition the README needs to be updated for the configuration options. |
Contributor
Author
|
No problem @lgebhardt. I'll get on it this weekend. Thanks for the update. |
Contributor
Author
|
All set @lgebhardt. Let me know if there's anything else. |
Contributor
|
@utilityboy Thanks! Should be quite useful. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option for top level
page_countmeta for paged paginators in addition to the record_count.A number of client-side paging libraries look for APIs to return a total page count.
Potential closes #126?