Callback rework#65
Merged
Merged
Conversation
Add callbacks for resource operation calls Rework OperationsProcessor callbacks
Contributor
There was a problem hiding this comment.
_remove and all the other underscored methods should be private.
Collaborator
|
I sent a PR to the |
Contributor
Author
|
@dgeb, I moved the new methods down into the private section. The other underscored methods that are public need to stay that way. |
Add README content for callbacks.
Contributor
|
@lgebhardt thanks for making those updates. Looks like there's still some public / private labeling and indentation confusion. |
Contributor
|
Great work @lgebhardt and @barelyknown! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the operations processor callbacks to use ActiveSupport callbacks.
Adds callbacks to resource operations.
Reworks create_has_many_link to create_has_many_links.