Conversation
Using ensure on rails 5 will get a "headers already sent" error
Rails 5 turns @scope into a linked list and you can no longer modify and individual scope but must create a new one with your extra data The methods here were modeled after it's own resource handling (setting the scope_level_resource is required due to their parent_resource checking)
…roller::Parameters which is how they are returned in rails 5 See http://eileencodes.com/posts/actioncontroller-parameters-now-returns-an-object-instead-of-a-hash/ for more information
Needed for rails 5 and works with rails 4
Needs to be cleared to allow multiple request calls in a single test
Rails 5 beta 3-compatible parameter parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 5 compatibility changes.
Switches tests over to rails5 testing format, and patches rails 4 for compatibility.